fix(ui): State CSS classes #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attitude
force-pushed
the
fix/state-css-classes
branch
2 times, most recently
from
9668be4 to
1166d46
Compare
This introduces `Button.accent` prop to set button "accent" allowing it to blend with content and apply theming only for hover/active/focus states.
attitude
force-pushed
the
fix/state-css-classes
branch
from
1166d46 to
0c54796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially deprecates usage of state class name variants of themes we used for adding danger-theme to some non-dominant delete buttons because the order of CSS causes to allow setting
:hoverand other states only for themes that were defined after the one we were trying to override.This will introduce a minor breaking change (planned for 1.3) for those who used the theming with states. It is recommended to use other means of changing themes when needed.
This PR adds feature to overcome this limitation on
Buttoncomponents:<button accent="theme" />:<button accent="strong" />:<button accent={false} />:This change is